dpgaspar commented on a change in pull request #12162:
URL:
https://github.com/apache/incubator-superset/pull/12162#discussion_r547140699
##########
File path: superset/dashboards/commands/importers/v1/utils.py
##########
@@ -81,6 +81,15 @@ def update_id_refs(config: Dict[str, Any], chart_ids:
Dict[str, int]) -> Dict[st
for old_id, value in metadata["expanded_slices"].items()
}
+ if "default_filters" in metadata:
Review comment:
nit: This switch type logic on `update_id_refs` if it grows (or even
now) is asking for a small refactor IMO
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
