agatapst commented on a change in pull request #12158:
URL:
https://github.com/apache/incubator-superset/pull/12158#discussion_r547188636
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FilterBar.tsx
##########
@@ -183,6 +184,12 @@ const StyledCaretIcon = styled(Icon)`
margin-top: ${({ theme }) => -theme.gridUnit}px;
`;
+const StyledLoadingBox = styled.div`
+ position: relative;
+ height: 32px;
Review comment:
Actually no, my bad. I think when writing this I had in mind that we use
gridUnit primarily for paddings and margins, but here the height is low and
it's actually better to use gridUnit. I will change it, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
