robdiciuccio commented on a change in pull request #12103:
URL:
https://github.com/apache/incubator-superset/pull/12103#discussion_r551460230
##########
File path: superset/common/query_context.py
##########
@@ -60,8 +60,8 @@ class QueryContext:
queries: List[QueryObject]
force: bool
custom_cache_timeout: Optional[int]
- result_type: utils.ChartDataResultType
- result_format: utils.ChartDataResultFormat
+ result_type: Union[utils.ChartDataResultType, str]
+ result_format: Union[utils.ChartDataResultFormat, str]
Review comment:
Yes, marshmallow schema validation was failing with the default
(unspecified) values for `result_type` and `result_format`. Essentially,
marshmallow and mypy cannot agree here. I tried using
https://pypi.org/project/marshmallow-enum/ here as well, to no avail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
