villebro commented on a change in pull request #12253:
URL:
https://github.com/apache/incubator-superset/pull/12253#discussion_r551508730
##########
File path: tests/databases/api_tests.py
##########
@@ -347,6 +347,7 @@ def test_create_database_fail_sqllite(self):
"""
Database API: Test create fail with sqllite
"""
+ app.config["PREVENT_UNSAFE_DB_CONNECTIONS"] = True
Review comment:
To make these even more resilient to flakery, I believe patching the
dict would be the best option here, like here:
https://github.com/apache/incubator-superset/blob/164db3e5a13c21137afb56a3044ef3f1aaf89e11/tests/charts/api_tests.py#L1108-L1110
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
