mistercrunch commented on a change in pull request #12210:
URL:
https://github.com/apache/incubator-superset/pull/12210#discussion_r551557453
##########
File path: superset-frontend/src/setup/setupColors.js
##########
@@ -49,4 +50,6 @@ export default function setupColors() {
});
});
sequentialSchemeRegistry.setDefaultKey('superset_seq_1');
+
+ setupColorsExtra();
Review comment:
Should we pass the context here as in
```js
const colorContext = {sequentialSchemeRegistry, categoricalSchemeRegistry};
setupColorsConfigHook(colorContext);
```
(or similar)? Otherwise we're assuming the users are importing arbitrary
objects and mutating them and it feels monkey-patchy...
I'm also wondering if we should have a central file for all the
configuration hooks, similar to `superset/config.py` on the python side?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
