rusackas commented on pull request #12250: URL: https://github.com/apache/incubator-superset/pull/12250#issuecomment-754449841
@junlincc up to you (and @maloun96) if you want to merge this, since it DOES solve the acute problem (thanks!), but I see that the Data table is not adjusting its height on window resize, which leads to two _other_ problems. We should tackle these problems in a follow-up PR, or (preferably, I think) address it in this one. 1) Start with a TALL window and open the data pane. Shorten the window. You'll see that the entire chart+table area scrolls due to the lack of table resize. Collapse and re-open the Data area, and you'll see the height is adjusted (no more scrollbar). https://user-images.githubusercontent.com/812905/103616825-fdf17500-4ee1-11eb-9970-919755364505.mp4 2) Start with a SHORT window an open the data pane. Lengthen the window. You'll see that the table is unnecessarily cropped off. Collapse and re-open the Data area, and you'll see the height is adjusted (no more cropping). https://user-images.githubusercontent.com/812905/103616970-38f3a880-4ee2-11eb-86ba-40314038af30.mp4 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
