betodealmeida opened a new pull request #12320: URL: https://github.com/apache/superset/pull/12320
### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR fixes dashboard export when the dashboard has 1+ orphan charts. When a chart is added to an existing dashboard it's not added to the `position_json` attribute, and its position is implicit. When we export the dashboard we need to add the "orphan" charts to the dashboard's `position_json` so the relationship is preserved. Currently, this only works when `position_json` doesn't exist. But there might exist dashboards were `position_json` exists **and** the dashboard has orphan charts. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> N/A ### TEST PLAN <!--- What steps should be taken to verify the changes --> Exported dashboard and verified that charts are added. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
