nikolagigic commented on a change in pull request #12257:
URL: https://github.com/apache/superset/pull/12257#discussion_r553327024
##########
File path: superset-frontend/spec/javascripts/explore/utils_spec.jsx
##########
@@ -202,20 +201,6 @@ describe('exploreUtils', () => {
});
});
- describe('getDataTablePageSize', () => {
- it('divides samples data into pages dynamically', () => {
- let pageSize;
- pageSize = getDataTablePageSize(500);
- expect(pageSize).toEqual(20);
- pageSize = getDataTablePageSize(0);
- expect(pageSize).toEqual(50);
Review comment:
Can we keep this test since we now got a constant for items per page?
Edit: Can we rewrite this test to check for number of items per page since
we now got `DATA_TABLE_PAGE_SIZE` set?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
