[GitHub] [superset] michael-s-molina commented on pull request #12326: fix: control panel fields styling (#12236)

[GitBox]

michael-s-molina commented on pull request #12326:
URL: https://github.com/apache/superset/pull/12326#issuecomment-756262185


   @nikolagigic Accepted all your suggestions. Thanks.
   
   I increased the width (320px to 380px) of both panels to support bigger 
inputs. We still have the situation of layout flicks when we hover elements 
because there is no space available for the tooltip icon and this creates a 
line break. In talks with @junlincc she told me that this is being fixed in 
another PR where we're going to stack all controls and this line break problem 
won't happen anymore. So I will limit the scope of this PR to just fixing input 
styles.
   
   For documentation purposes these images bellow show some examples where a 
line break happens:
   
   <img width="782" alt="Screen Shot 2021-01-07 at 2 22 30 PM" 
src="https://user-images.githubusercontent.com/70410625/103923664-205adc80-50f4-11eb-8463-afce92ac7e2d.png";>
   <img width="777" alt="Screen Shot 2021-01-07 at 2 27 00 PM" 
src="https://user-images.githubusercontent.com/70410625/103924186-77f94800-50f4-11eb-8b1a-2e9611b130a4.png";>
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org