nytai edited a comment on pull request #12315:
URL: https://github.com/apache/superset/pull/12315#issuecomment-756295935


   @ktmud superset currently has an events tracking system where events are 
relayed to a backend system, which can then relayed to a generic events 
tracking system. My example of google analytics was probably not the best. Full 
context, we will be using this config to add 
[pendo](https://support.pendo.io/hc/en-us/articles/360031862272-Installation-for-Single-Page-Frameworkshttps://support.pendo.io/hc/en-us/articles/360031862272-Installation-for-Single-Page-Frameworks)
 which mentions not needing any special config for single-page apps. Something 
like [intercom](https://www.intercom.com/) or 
[fullstory](https://www.fullstory.com/) would work similarly. 
   
   I don't think replacing a file before building the frontend will work for 
our use case given that we're relying on the `render_template_string` to 
populate a few values in the script (eg, current_user.id).
   
   re: security, I'll add the disclaimer to the config file. This does open up 
a potential attack vector, however there are many other ways in which people 
configuring superset can shoot themselves in the foot. In general people 
configuring and deploying and app should be aware of what they're doing, 
especially in prod-like environments. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to