riahk opened a new pull request #12341: URL: https://github.com/apache/superset/pull/12341
### SUMMARY - [x] Handles errors on save/update so modal does not close when an error is encountered - [x] utilizes `useEffect` hook for initialization to reduce API requests ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TEST PLAN Manual Test: 1. Create or update annotation/annotation layer with duplicate name 2. Attempt to save 3. Confirm that an error toast is thrown and the modal does not close ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [x] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
