ktmud edited a comment on pull request #12257:
URL: https://github.com/apache/superset/pull/12257#issuecomment-756967446
The performance problem seems fixed. However, while testing, I found a
couple of more bugs (some of them probably not related to this PR):
1. Change datasource does not update the samples
2. Previously the chart control values are persisted when editing an
existing chart (e.g. if you change something, hit "Run", and refresh the page,
your edits are persisted in the URL, even without saving the chart). This is
now broken.
3. We probably shouldn't show "0 rows" in an error state while it is still
loading:
<img
src="https://user-images.githubusercontent.com/335541/104058354-71c4a380-51a8-11eb-8f18-6b6f5294f25e.png";
width="500">
4. Many styling issues:
<img
src="https://user-images.githubusercontent.com/335541/104058442-96208000-51a8-11eb-8192-2f5b9d6cc70e.png";
width="500">
a) search input is cut off
b) sort icons break into another line
This happens when there are too many columns (tested with the
`wh_health_data` dataset)
5. Scrolling (both horizontally and vertically) moves the pagination bar
which makes it almost unusable.
Not sure how feasible it is, maybe it's worth looking into rendering this
table with `DataTable` from the table viz plugin. It handles many rendering
issues like 4 and 5. I had a plan to generalize that implementation, but didn't
have time to finish. If someone can pick it up from where it was left, that
would also be great.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/335541/104058354-71c4a380-51a8-11eb-8f18-6b6f5294f25e.png"](https://user-images.githubusercontent.com/335541/104058354-71c4a380-51a8-11eb-8f18-6b6f5294f25e.png"){kind=link}
![https://user-images.githubusercontent.com/335541/104058442-96208000-51a8-11eb-8192-2f5b9d6cc70e.png"](https://user-images.githubusercontent.com/335541/104058442-96208000-51a8-11eb-8192-2f5b9d6cc70e.png"){kind=link}
