rusackas commented on a change in pull request #12365:
URL: https://github.com/apache/superset/pull/12365#discussion_r554246169
##########
File path: superset-frontend/src/explore/components/DatasourcePanel.tsx
##########
@@ -131,7 +131,8 @@ const DatasourceContainer = styled.div`
color: ${({ theme }) => theme.colors.grayscale.light1};
}
.form-control.input-sm {
- margin-bottom: 0;
+ width: 96%;
Review comment:
This 96% jumped out at me as a little funny... is there supposed to be
some number of pixels on each side of the element? Maybe something like `width:
calc(100% - ${({ theme }) => theme.gridUnit * 2}px);` would make sense (or
whatever the gutter measurement should be?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
