geido commented on a change in pull request #12390:
URL: https://github.com/apache/superset/pull/12390#discussion_r554468638
##########
File path: superset-frontend/src/explore/exploreUtils.js
##########
@@ -288,8 +288,9 @@ export const exploreChart = formData => {
postForm(url, formData);
};
-export const useDebouncedEffect = (effect, delay) => {
- const callback = useCallback(effect, [effect]);
+export const useDebouncedEffect = (effect, delay, deps) => {
+ // eslint-disable-next-line react-hooks/exhaustive-deps
+ const callback = useCallback(effect, deps);
Review comment:
This will cause the issue to happen again unofrtunately
##########
File path: superset-frontend/src/explore/exploreUtils.js
##########
@@ -288,8 +288,9 @@ export const exploreChart = formData => {
postForm(url, formData);
};
-export const useDebouncedEffect = (effect, delay) => {
- const callback = useCallback(effect, [effect]);
+export const useDebouncedEffect = (effect, delay, deps) => {
+ // eslint-disable-next-line react-hooks/exhaustive-deps
+ const callback = useCallback(effect, deps);
Review comment:
This will cause the issue to happen again unfortunately
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
