ktmud commented on a change in pull request #12401:
URL: https://github.com/apache/superset/pull/12401#discussion_r554668533
##########
File path:
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterControl.tsx
##########
@@ -181,27 +182,42 @@ export default function DateFilterControl(props:
DateFilterLabelProps) {
const [timeRangeValue, setTimeRangeValue] = useState(value);
const [validTimeRange, setValidTimeRange] = useState<boolean>(false);
const [evalResponse, setEvalResponse] = useState<string>(value);
+ const [tooltipTitle, setTooltipTitle] = useState<string>(value);
useEffect(() => {
- const valueToLower = value.toLowerCase();
- if (
- valueToLower.startsWith('last') ||
- valueToLower.startsWith('next') ||
- valueToLower.startsWith('previous')
- ) {
- setActualTimeRange(value);
- setValidTimeRange(true);
- } else {
- fetchTimeRange(value, endpoints).then(({ value, error }) => {
- if (error) {
- setEvalResponse(error || '');
- setValidTimeRange(false);
+ fetchTimeRange(value, endpoints).then(({ value: actualRange, error }) => {
+ if (error) {
+ setEvalResponse(error || '');
+ setValidTimeRange(false);
+ setTooltipTitle(value || '');
+ } else {
+ /*
+ HRT == human readable text
+ ADR == actual datetime range
+ +--------------+------+----------+--------+----------+-----------+
+ | | Last | Previous | Custom | Advanced | No Filter |
+ +--------------+------+----------+--------+----------+-----------+
+ | control pill | HRT | HRT | ADR | ADR | ADR |
+ +--------------+------+----------+--------+----------+-----------+
+ | tooltip | ADR | ADR | HRT | HRT | HRT |
+ +--------------+------+----------+--------+----------+-----------+
+ */
+ const valueToLower = value.toLowerCase();
+ if (
+ valueToLower.startsWith('last') ||
+ valueToLower.startsWith('next') ||
+ valueToLower.startsWith('previous')
+ ) {
+ setActualTimeRange(value);
+ setValidTimeRange(true);
Review comment:
It seems `setValidTimeRange(true);` can be moved out of `if` branches.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
