geido commented on a change in pull request #12391:
URL: https://github.com/apache/superset/pull/12391#discussion_r555189759
##########
File path: superset-frontend/src/datasource/ChangeDatasourceModal.tsx
##########
@@ -224,6 +221,7 @@ const ChangeDatasourceModal:
FunctionComponent<ChangeDatasourceModalProps> = ({
onHide={onHide}
responsive
title={t('Change Dataset')}
+ height="350px"
Review comment:
I think it is preferable to avoid specifying px just in case another
unit needs to be used, see a percentage, for instance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
