geido opened a new pull request #12410:
URL: https://github.com/apache/superset/pull/12410


   ### SUMMARY
   Setting the option `menuPortalTarget` of the react-bootstrap Select 
component is necessary in order for the dropdowns to properly show when 
overlaying container elements. However, setting the `menuPortalTarget` to 
`document.body` (as originally the multi-choice dropdown did and later the 
single-choice) comes with several other issues, such as problems with the 
z-index and click events being targeted outside of the container elements, 
which ultimately cause this issue #12388 
   
   This PR fixes the z-index issues and the click targets issue by creating a 
`div` container element around the Select component and uses that as the 
`menuPortalTarget` for both single-choice and multi-choice dropdowns while 
setting the `menuPosition` to `fixed`.
   
   Closes #12388 
   Removes excessive z-index introduced by #12327 
   Closes #12310 probably to prefer over #12406
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   1. Open the single and multi-choice dropdowns throughout the project
   2. Make sure the dropdowns are displaying correctly
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: #12388 #12310
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to