ktmud commented on a change in pull request #12404:
URL: https://github.com/apache/superset/pull/12404#discussion_r555247433
##########
File path: superset-frontend/src/explore/components/DataTablesPane.tsx
##########
@@ -73,16 +73,21 @@ export const DataTablesPane = ({
queryFormData,
tableSectionHeight,
onCollapseChange,
+ chartStatus,
}: {
queryFormData: Record<string, any>;
tableSectionHeight: number;
onCollapseChange: (openPanelName: string) => void;
+ chartStatus: string;
Review comment:
Can this be string literals or some shared typing as I assume there are
only a limited set of state?
##########
File path: superset-frontend/src/explore/components/DataTablesPane.tsx
##########
@@ -73,16 +73,21 @@ export const DataTablesPane = ({
queryFormData,
tableSectionHeight,
onCollapseChange,
+ chartStatus,
}: {
queryFormData: Record<string, any>;
tableSectionHeight: number;
onCollapseChange: (openPanelName: string) => void;
+ chartStatus: string;
Review comment:
Can this be string literals or some shared typing as I assume there are
only a limited set of states?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
