eschutho opened a new issue #12429:
URL: https://github.com/apache/superset/issues/12429


   The tooltip for the new tab instructs users to use `Ctrl + t` for a new tab, 
but this doesn't work on a PC.
   <img width="585" alt="_DEV__Superset" 
src="https://user-images.githubusercontent.com/5186919/104260080-94202080-5437-11eb-8344-ed014ca9b5c0.png";>
   
   Suggested solution: change the tooltip to suggest using `Ctrl +q` for PC 
users and update the keyboard shortcuts. 
   
   ### Expected results
   
   The instructions in the tooltip should open a new SQL Lab tab.
   
   ### Actual results
   
   Following the instructions on a PC opens a new Chrome tab.
   
   #### How to reproduce the bug
   
   1. Go to `/superset/sqllab`
   2. Hover over the "+" icon next to the tabs for the instructions
   3. Hit `Ctrl + t` in Chrome on a PC
   4. A new Chrome tab opens
   
   ### Environment
   
   - superset version: `1.0`
   
   ### Checklist
   
   Make sure to follow these steps before submitting your issue - thank you!
   
   - [x] I have checked the superset logs for python stacktraces and included 
it here as text if there are any.
   - [x] I have reproduced the issue with at least the latest released version 
of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't 
found one similar. (Closed that issue for this one which is more accurate given 
the recent changes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to