Steejay commented on a change in pull request #12453:
URL: https://github.com/apache/superset/pull/12453#discussion_r556027609
##########
File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx
##########
@@ -592,7 +592,7 @@ class SqlEditor extends React.PureComponent {
}}
key="1"
>
- {t('CREATE TABLE AS')}
+ {t('Create table as')}
Review comment:
```suggestion
{t('Create table as')}
```
CREATE TABLE AS is an outlier in this situation. We want to mimic the SQL
language in this case so we're displaying this text as all caps. In this
instance the correct form should be 'CREATE TABLE AS'
##########
File path: superset-frontend/src/middleware/asyncEvent.ts
##########
@@ -79,7 +79,7 @@ const initAsyncEvents = (options: AsyncEventOptions) => {
try {
lastReceivedEventId = localStorage.getItem(LOCALSTORAGE_KEY);
} catch (err) {
- console.warn('failed to fetch last event Id from localStorage');
+ console.warn('Failed to fetch last event id from localStorage');
Review comment:
Change to: "Failed to fetch last event Id from localStorage" since Id is
an abbreviation of identifier.
##########
File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx
##########
@@ -605,7 +605,7 @@ class SqlEditor extends React.PureComponent {
}}
key="2"
>
- {t('CREATE VIEW AS')}
+ {t('Create view as')}
Review comment:
CREATE VIEW AS is an outlier in this situation. We want to mimic the SQL
language in this case so we're displaying this text as all caps. In this
instance the correct form should be 'CREATE VIEW AS'
##########
File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx
##########
@@ -696,8 +696,8 @@ class SqlEditor extends React.PureComponent {
render() {
const createViewModalTitle =
this.state.createAs === CtasEnum.VIEW
- ? 'Create View As'
- : 'Create Table As';
+ ? 'Create view as'
+ : 'Create table as';
Review comment:
CREATE VIEW AS and CREATE TABLE AS are outliers in this situation. We
want to mimic the SQL language in this case so we're displaying this text as
all caps. In this instance the correct form should be 'CREATE VIEW AS' and
'CREATE TABLE AS'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
