geido edited a comment on pull request #12410: URL: https://github.com/apache/superset/pull/12410#issuecomment-758916887
I have cleaned up the things a bit. The `menuPortalTarget` wasn't really needed and I removed it. What is needed is only the `menuPosition` to be `fixed` for instances where setting the overflow to visible on the container element isn't viable. I made that optional as well by introducing a `forceOverflow` option so that individual cases can be handle appropriately. Finally, when the option`forceOverflow` is used, I am closing the dropdown on scroll when the target of the scroll isn't the dropdown itself so that issue mentioned by @adam-stasiak and @kkucharc is at least partially mitigated. https://user-images.githubusercontent.com/60598000/104368329-3580a280-551c-11eb-82fd-261fdb3d8794.mp4 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
