betodealmeida opened a new pull request #12472: URL: https://github.com/apache/superset/pull/12472
### SUMMARY <!--- Describe the change below, including rationale and design decisions --> When switching away from a SQL tab with results and back again, the results don't show up because the height of the component is computed incorrectly. I fixed it by simply reusing the height passed as props. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> How to repro: 1. Go to SQL Lab and run a query with results 2. Switch to another tab 3. Switch back 4. No results are displayed With this PR, it works as expected: https://user-images.githubusercontent.com/1534870/104369922-fed26a00-54d2-11eb-8a67-078f0bc377a1.mov ### TEST PLAN <!--- What steps should be taken to verify the changes --> See above. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
