geido edited a comment on pull request #12410: URL: https://github.com/apache/superset/pull/12410#issuecomment-758916887
I have cleaned up the things a bit. The `menuPortalTarget` wasn't really needed and I removed it. What is needed is only the `menuPosition` to be `fixed` for instances where setting the `overflow` `visible` on the container element isn't viable. I made that optional as @ktmud suggested by introducing a `forceOverflow` option so that individual cases can be handled appropriately. When the option`forceOverflow` is used, I am closing the dropdown on scroll (when the target of the scroll isn't the dropdown itself). In this way, the react-select issue (https://github.com/JedWatson/react-select/issues/4088) mentioned by @adam-stasiak and @kkucharc is at least _partially_ mitigated. It seems that the `forceOverflow` option is currently only required for the filters in the Dashboards. The undesired react-select behavior with scrolling should have a low impact in any case. The video below shows the new behavior. I have also updated the PR description to better detail the problem and the chosen solution. https://user-images.githubusercontent.com/60598000/104368329-3580a280-551c-11eb-82fd-261fdb3d8794.mp4 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
