ktmud opened a new pull request #12483: URL: https://github.com/apache/superset/pull/12483
### SUMMARY Fixes #12480 1. Always use datasource uid (or `parameter`, or `key`, whatever you call it) from the `slice.datasource_id` and `slice.datasource_type`, instead of the `datasource` field stored in `form_data` (`slice.params`), as they can be out of sync. 2. Update the import scripts to account for this and update `datasource` in `slice.params` with real dataset id associated with uuid. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF #### Before Adding charts from the new samples data in dashboard edit mode throws an error:  #### After It does not throw an error  ### TEST PLAN CI ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: #12163 #12162 #12480 - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
