villebro commented on a change in pull request #12490:
URL: https://github.com/apache/superset/pull/12490#discussion_r556387241
##########
File path: superset/db_engine_specs/postgres.py
##########
@@ -18,6 +18,7 @@
from datetime import datetime
from typing import Any, Dict, List, Optional, Tuple, TYPE_CHECKING
+from psycopg2 import errors
Review comment:
We need to move this import into the method, as `psycopg2` isn't a
required dependency.
##########
File path: tests/db_engine_specs/postgres_tests.py
##########
@@ -16,6 +16,7 @@
# under the License.
from unittest import mock
+from psycopg2 import errors
Review comment:
same here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
