geido commented on a change in pull request #12410:
URL: https://github.com/apache/superset/pull/12410#discussion_r556566496
##########
File path: superset-frontend/src/components/Select/SupersetStyledSelect.tsx
##########
@@ -243,6 +244,18 @@ function styled<
});
}
+ // handle forcing dropdown overflow
+ // use only when setting overflow:visible isn't possible on the container
element
+ if (forceOverflow) {
Review comment:
Yes you can see two instances in this PR already. One is on the
dashboard filters and the other one is used for the refresh-interval modal. The
one for the dashboard filters is required. The one for refresh-interval is more
to show how it looks like on a modal but it is not necessary and can be
removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]