[GitHub] [superset] eschutho commented on a change in pull request #12423: fix: incorrect cursor position Firefox

[GitBox]

eschutho commented on a change in pull request #12423:
URL: https://github.com/apache/superset/pull/12423#discussion_r556716051



##########
File path: superset-frontend/src/SqlLab/main.less
##########
@@ -378,7 +378,9 @@ div.tablePopover {
   //double class is better than !important
   border: 1px solid @gray-light;
   font-feature-settings: @font-feature-settings;
-  font-family: @font-family-monospace;
+  // Fire Code causes problem with Ace under Firefox
+  font-family: 'Menlo', 'Courier New', 'Ubuntu Mono', 'Consolas',
+    'source-code-pro', monospace;

Review comment:
       Two small things..We could target just the bold typeface by using the 
selector `.ace_editor.ace_editor .ace_keyword` if we wanted to just change the 
bold typeface. Also talking with @Steejay can we try 'Lucida Console' instead 
of 'Courier New'? Here's the comparison for reference:
   <img width="1145" alt="_DEV__Superset" 
src="https://user-images.githubusercontent.com/5186919/104489541-98a61f80-5584-11eb-8c4a-1e5ed143b333.png";>
   <img width="1098" alt="_DEV__Superset" 
src="https://user-images.githubusercontent.com/5186919/104489561-a196f100-5584-11eb-94f5-977148940771.png";>
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org