geido opened a new pull request #12502: URL: https://github.com/apache/superset/pull/12502
### SUMMARY Closes #12469 Fixes jumpiness of the Datasource modal ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF BEFORE OVERFLOW: https://user-images.githubusercontent.com/67837651/104363247-c5493100-54c9-11eb-9b6f-ded5f033985c.mp4 AFTER OVERFLOW: https://user-images.githubusercontent.com/60598000/104509523-17817380-55ea-11eb-8701-81c6fdb5c16b.mp4 BEFORE JUMPINESS: https://user-images.githubusercontent.com/60598000/104509562-210adb80-55ea-11eb-8344-d9d753eb0d89.mp4 AFTER JUMPINESS: https://user-images.githubusercontent.com/60598000/104509580-26682600-55ea-11eb-92f6-efe86d1192ac.mp4 ### TEST PLAN 1. Open any modal that contains dropdowns. 2. Make sure dropdowns are overflowing the modal content 3. Open the datasource modal in Explore 4. Make sure the modal has a fixed height and jumpiness is removed ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: #12469 - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
