[GitHub] [superset] agatapst opened a new pull request #12519: Reset column field for removed dataset

Thu, 14 Jan 2021 03:18:43 -0800 


agatapst opened a new pull request #12519:
URL: https://github.com/apache/superset/pull/12519


   ### SUMMARY
   After removing dataset, which is used in some native filter, it was still 
possible to see field from this dataset. Dataset was removed, but field value 
was not removed from Filter Config Modal.
   Described in #12457
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   First we set some native filter
   <img width="1643" alt="remove_dataset_before" 
src="https://user-images.githubusercontent.com/47450693/104583731-ca40e880-5661-11eb-8988-8c18e7dda510.png";>
   Then we remove used dataset and come back to native filter config
   
![dataset_remove](https://user-images.githubusercontent.com/47450693/104583846-ee042e80-5661-11eb-98a1-b5710b0e9041.gif)
   
   After:
   <img width="1615" alt="remove_dataset_after" 
src="https://user-images.githubusercontent.com/47450693/104583752-d036c980-5661-11eb-9a4c-245b356be4c6.png";>
   
![dataset_remove_after](https://user-images.githubusercontent.com/47450693/104583823-e6dd2080-5661-11eb-8d8f-2575b1c397d7.gif)
   
   ### TEST PLAN
   Set `"DASHBOARD_NATIVE_FILTERS": True`
   Create new native filter with given dataset
   Go to datasets and remove this dataset
   Come back to native filter you have just created and check if you see 
'Select' placeholder instead of field value from removed dataset
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: Fixes #12457
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   @junlincc @rusackas @adam-stasiak 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to