ktmud opened a new pull request #12537:
URL: https://github.com/apache/superset/pull/12537


   ### SUMMARY
   
   Before #12147 and #12091, FilterBox is considered a timeseries viz, and has 
a Time section where users can set time granularity and time filter. This adds 
it back so people can still use Time filter on FilterBox and the existing 
charts that do use it doesn't break.
   
   In the future, we should probably bring the TimeFilter to regular 
AdhocFilter, as long as a column is temporal. This way we convert FilterBox 
into a non-timeseries viz. But since we are investing in native filters, this 
is probably not necessary anyway.
   
   (cc @zhaoyongjie @junlincc )
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   #### Before
   
   FilterBox has no Time section (incorrectly removed)
   
   
![image](https://user-images.githubusercontent.com/335541/104682451-8c67b280-56a9-11eb-8783-f470354b3648.png)
   
   
   #### After
   
   
![image](https://user-images.githubusercontent.com/335541/104682408-73f79800-56a9-11eb-8ced-98d21a4a040d.png)
   
   Time section is added back.
   
   ### TEST PLAN
   
   - Go to Explore a filter box viz
   - You should see the Time section
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: see summary
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to