[GitHub] [superset] agatapst opened a new pull request #12554: Feat(native-filters): Show alert for unsaved filters after cancelling Filter Config Modal

Fri, 15 Jan 2021 09:43:42 -0800 


agatapst opened a new pull request #12554:
URL: https://github.com/apache/superset/pull/12554


   ### SUMMARY
   The aim was to show info at the bottom of Native Filter Config Modal when 
users clicks 'cancel'.
   Now we want the user to confirm this decision when there are unsaved filters.
   Fixes #12459
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Confirming cancel:
   
![canceling_filters](https://user-images.githubusercontent.com/47450693/104759548-5afdee00-5760-11eb-9419-ee69df2e7ce6.gif)
   
   Remove incorrect 
   
![removing_incorrect_alert](https://user-images.githubusercontent.com/47450693/104759593-6c46fa80-5760-11eb-8341-c117d2127ebf.gif)
   
   Alert with long filter names:
   <img width="978" alt="long_filters" 
src="https://user-images.githubusercontent.com/47450693/104760233-5d147c80-5761-11eb-921c-bcae16917906.png";>
   
   ### TEST PLAN
   Set `"DASHBOARD_NATIVE_FILTERS": True`
   Create native filter
   Click Cancel
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: #12459
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   cc @junlincc @rusackas @villebro 
   @adam-stasiak please test it 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to