villebro opened a new pull request #12581:
URL: https://github.com/apache/superset/pull/12581


   ### SUMMARY
   Currently the BigQuery engine spec only supports full seconds/minutes/hours 
due to the dialect not natively supporting custom intervals. This PR adds 
support for the missing default 5, 10, 15 and 30 min grains by utilizing some 
custom timestamp handling functions:
   
   ### Screenshot
   
![image](https://user-images.githubusercontent.com/33317356/104903270-75b2ab80-5988-11eb-8251-6be14582d4c2.png)
   
   ### TEST PLAN
   Verified to work on `TIMESTAMP`, `DATETIME` and `DATE` types + added new 
unit tests.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to