kgabryje opened a new pull request #12582: URL: https://github.com/apache/superset/pull/12582
### SUMMARY Currently a user can edit a name of saved metric in popover, but the change doesn't show anywhere, because this feature is not implemented for saved metrics yet. This PR disables name edit feature for saved metrics. Also, now "Saved" is a default tab in Metrics popover. When user opens a popover, "Saved" tab is selected by default, unless there are no saved metrics for current dataset. Closes https://github.com/apache/superset/issues/12578 ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF https://user-images.githubusercontent.com/15073128/104911028-8532f400-598a-11eb-89d8-2e3f0117f649.mov ### TEST PLAN <!--- What steps should be taken to verify the changes --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: https://github.com/apache/superset/issues/12578 - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API CC: @junlincc @villebro @ktmud ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
