junlincc edited a comment on pull request #12582: URL: https://github.com/apache/superset/pull/12582#issuecomment-762631986
> +1 on allowing saving adhoc metric in place. will have to wait until metrics refactoring work is done. @zhaoyongjie @kgabryje let's show the metrics' name on the popover. that will be the scope of this PR. oh and please fix the failing test. thanks both! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
