ktmud commented on a change in pull request #12598:
URL: https://github.com/apache/superset/pull/12598#discussion_r560379179
##########
File path: superset-frontend/src/common/components/Modal/Modal.tsx
##########
@@ -42,12 +42,15 @@ interface ModalProps {
footer?: React.ReactNode;
wrapProps?: object;
height?: string;
+ scrollTableMode?: boolean;
}
interface StyledModalProps extends SupersetThemeProps {
maxWidth?: string;
responsive?: boolean;
height?: string;
+ scrollTableMode?: boolean;
Review comment:
Do we really need both props for the modal? And I think it's OK to keep
some bottom padding when only table body is scrollable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
