villebro commented on a change in pull request #12583:
URL: https://github.com/apache/superset/pull/12583#discussion_r560735370
##########
File path: .github/workflows/test-presto.yml
##########
@@ -42,11 +42,22 @@ jobs:
- 16379:6379
steps:
- uses: actions/checkout@v2
+ - name: Check if python changes are present
+ id: check
+ env:
+ GITHUB_REPO: ${{ github.repository }}
+ PR_NUMBER: ${{ github.event.pull_request.number }}
+ continue-on-error: true
+ run: |
+ ./scripts/ci_check_python_changes.sh
+ ./scripts/ci_check_python_test_changes.sh
Review comment:
> > Anyway, I still don't think you can skip `test/*.py` for E2E tests.
>
> are we? I'm not seeing any changes to `superset-e2e.yml`
I wanted to keep the scope of this PR as small as possible, hence didn't het
add the E2E changes. Once this is merged I'll add similar logic to frontend and
E2E tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
