mihir174 edited a comment on pull request #12580: URL: https://github.com/apache/superset/pull/12580#issuecomment-763403657
@zhaoyongjie If there's a page with the syntax info in Superset docs, we should link to that. If that doesn't exist yet, I think staying in context and having the huge modal makes sense for now. For the tooltip: 1) i think it would be better if the tooltip didn't cover the inputs - then the user could type while keeping the mouse hovered on the tooltip icon to refer to the syntax 2) @junlincc a persistent tooltip breaks a lot of UI patterns and will be inconsistent. i think if the tooltip doesn't obscure the inputs, users should be able to refer to the content easily 3) here's the correct tooltip icon - https://www.figma.com/file/ToYikUoHLg7fhIBUPZtZb0/Superset-Design-System?node-id=968%3A125277 4) tooltip icon color should be Grey-4 (B2B2B2)  ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
