ktmud commented on a change in pull request #12482:
URL: https://github.com/apache/superset/pull/12482#discussion_r560822622
##########
File path: superset/connectors/sqla/utils.py
##########
@@ -0,0 +1,117 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review comment:
Can we maybe rename this file to something like `query_generator.py`? We
should stop creating more kitchen-sink `utils` files as they will unavoidably
grow larger and larger---and eventually unmaintainable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
