agatapst edited a comment on pull request #12519:
URL: https://github.com/apache/superset/pull/12519#issuecomment-763567691


   Thanks @mihir174 🙂 
   Could we make this message more generic, universal? We could show it for all 
errors connected with a given filter in the Filter Bar. Right now it is 
impossible to distinguish if the error comes exactly from removing dataset. It 
may be one of the reasons that loading filter is not possible - but for example 
the reason may be that some used in this filter field was removed from dataset. 
So it won't be the same as 'dataset removed'. 
   Maybe we can just tell the user to 'check configuration'? In the Config 
Modal the user is "taken" to this filter and can see what is going on.
   <img width="289" alt="Zrzut ekranu 2021-01-20 o 14 46 00" 
src="https://user-images.githubusercontent.com/47450693/105183230-3de56880-5b2e-11eb-8d92-8d588915af98.png";>
   
   
   
   cc @junlincc 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to