bryanck opened a new pull request #12621:
URL: https://github.com/apache/superset/pull/12621


   ### SUMMARY
   The FilterBox visualization renders an unnecessary horizontal scroll bar 
when a time range filter control is present. On some browsers (e.g. 
   ![Screen Shot 2021-01-20 at 6 19 06 
AM](https://user-images.githubusercontent.com/5475421/105187370-90e7fd00-5ae7-11eb-9aee-03c5699459d7.png)
   Safari), this scroll bar can get in the way of the drop down if the drop 
down is near the scroll bar. This PR removes the overflow CSS property causing 
this.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before:
   ![Screen Shot 2021-01-20 at 6 19 06 
AM](https://user-images.githubusercontent.com/5475421/105187388-95acb100-5ae7-11eb-909f-fd5448ae1587.png)
   
   After:
   ![Screen Shot 2021-01-20 at 6 19 24 
AM](https://user-images.githubusercontent.com/5475421/105187417-9e04ec00-5ae7-11eb-8f8a-0f23e7c1d81e.png)
   
   ### TEST PLAN
   Create a filter box and check the `Date filter` option. An unneeded 
horizontal scroll bar should show up. This happens both in the chart explore 
and if on a dashboard.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [*] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to