ktmud commented on a change in pull request #12620:
URL: https://github.com/apache/superset/pull/12620#discussion_r561206103
##########
File path: superset/utils/core.py
##########
@@ -1025,8 +1025,8 @@ def get_filter_key(f: Dict[str, Any]) -> str:
for existing in adhoc_filters:
if (
existing["expressionType"] == "SIMPLE"
- and existing["comparator"] is not None
- and existing["subject"] is not None
+ and "comparator" in existing
+ and "subject" in existing
Review comment:
Maybe use `existing.get("subject") is not None` to make sure the logic
is still the same?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
