[GitHub] [superset] adam-stasiak commented on pull request #12524: fix(native-filters): Improve UI for long native filters names

[GitBox]

adam-stasiak commented on pull request #12524:
URL: https://github.com/apache/superset/pull/12524#issuecomment-764028179


   I can see that very long single word names are cutted in the end:
   
![image](https://user-images.githubusercontent.com/25153919/105253591-13240000-5b80-11eb-90f7-bceaf09d9802.png)
   
   I am not sure how it should be handled - one case I consider to move after X 
characters to the next line. Second option obvious for me is to add "...". 
   @junlincc @mihir174  What do you think?
   
   My second doubt is whether we should display the same lines number in edit 
modal and in the left tab? Not it is different.
   
![image](https://user-images.githubusercontent.com/25153919/105253839-92b1cf00-5b80-11eb-805c-aa9950655a83.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org