[GitHub] [superset] ktmud opened a new pull request #12649: fix: explore page style fix, remove unnecessary scroll bars

[GitBox]

ktmud opened a new pull request #12649:
URL: https://github.com/apache/superset/pull/12649


   ### SUMMARY
   
   Various style fix on Explore page. Remove unnecessary scrollbars and make 
select dropdowns more selectable. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   #### Before
   
   
![Snip20210120_202](https://user-images.githubusercontent.com/335541/105318567-8c1f5980-5b78-11eb-8c8f-49396a4e7df2.png)
   
   <img 
src="https://user-images.githubusercontent.com/335541/105318808-d4d71280-5b78-11eb-8de2-d5829bbbf24b.png";
 width="400">
   
   #### After
   
   
![Snip20210120_203](https://user-images.githubusercontent.com/335541/105318584-90e40d80-5b78-11eb-80a1-71a52f71ba4b.png)
   
   <img 
src="https://user-images.githubusercontent.com/335541/105318875-e6201f00-5b78-11eb-8e95-02cfd6dd968a.png";
 width="400">
   
   1. Remove unnecessary scroll bars
   2. Remove mysterious box shadow in chart panel
   3. Add extra spacing to dropdown menus close to container bottom when opened
   4. Allow horizontal scrolls for the dropdown menus so users can see full 
text of all options (wanted to allow auto-width like in SQL Lab table selector 
(see below), but it turns out to be much harder to do on the Explore page. We 
should probably just use `position: absolute` columns once #12593 is merged). 
   
   <img 
src="https://user-images.githubusercontent.com/335541/105319232-6a72a200-5b79-11eb-9bc0-df92a9196fc6.png";
 width="500">
   
   We should probably also revert the metrics/columns select in 
AdhocMetric/Filter popover back to `react-select` so that the same solution can 
be applied to fix #12640 .
   
   ### TEST PLAN
   
   Visual verification.
   
   I recommend testing on the "Country of Citizenship" chart.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org