kgabryje opened a new pull request #12657: URL: https://github.com/apache/superset/pull/12657
### SUMMARY When the same saved metric is added twice to controls, the copies are indistinguishable - when the user tries to edit one saved metric, both are getting edited. This PR disables the possibility of adding the same saved metric more than once. Fixes https://github.com/apache/superset/issues/12611 Closes https://github.com/apache/superset/issues/12611 ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF https://user-images.githubusercontent.com/15073128/105353698-dc85ce00-5bef-11eb-8ce3-e38e072d89e4.mov ### TEST PLAN <!--- What steps should be taken to verify the changes --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: https://github.com/apache/superset/issues/12611 - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API CC: @junlincc @villebro @john-bodley @ktmud @adam-stasiak This PR replaces https://github.com/apache/superset/pull/12619 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
