garden-of-delete commented on issue #12566: URL: https://github.com/apache/superset/issues/12566#issuecomment-765005017
Would be happy to contribute the automation i'm proposing above as well. re: "Oftentimes breaking changes are caught by reviewers/committers that the author didn't even know of." That seems to suggest tags as the preferred vehicle for flagging PRs that contribute breaking changes. A contributor may move on from the project after adding changes that are later identified to be breaking. I think it makes sense for committers to have oversight on ensuring those PRs are flagged after being merged. Just my 2c. Somewhat tangential, but is there a way enable contributors to ask the label bot to add a label from a defined set of "temporary/tenative labels" that are removed at merge time? That would allow us to keep everything in tags, but still allow contributors to identify their own PR as potentially breaking during the initial submission or review process. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
