betodealmeida edited a comment on pull request #12635: URL: https://github.com/apache/superset/pull/12635#issuecomment-764064463
> I know hashing is fast for most cases, but I'm wondering whether we can move this to be an offline job in some way? > > I.e. instead of a decorator, store the hash for all public APIs in a separate file and run the checks in CI. Good point... we could also just add unit tests that import the functions and compare their signature hashes to hard coded values, that might be a more efficient approach. (Also, the hashes are computed just once when the files are "compiled", not when the functions are called.) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
