adam-stasiak commented on pull request #12554: URL: https://github.com/apache/superset/pull/12554#issuecomment-764007447
@junlincc @agatapst Tested and looks nice. I found different issue which may be connected with this a little bit but it was already in master. 🟡 Scenario: Go to native filter add 2 filters and save Open edit modal again and add new filter (without filling data) and delete name of first filter Cancel edition - confirm you want to lost your changes Open modal again - > you can see on filter list that name is blank but in filter name we have a blank value. In this PR this kind of change will not be captured by warning. Are you able @agatapst to catch this case as well?   ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
