amitmiran137 edited a comment on pull request #12680: URL: https://github.com/apache/superset/pull/12680#issuecomment-765341484
> Could you add a test plan and maybe some test cases? > > I think we should at least test visiting the dashboards list page as each of the following: > > 1. an anonymous user > 2. a non-admin (test user: alpha/general) > 3. admin I've added those to the test plan. I plan to start implementing the tests once we [vote](https://lists.apache.org/thread.html/r91c0acde742a9a719a30938d708e945890ade944ea476dc1def61975%40%3Cdev.superset.apache.org%3E) for the SIP is approved. can you vote please so we. can move forward with this in a non-POC approach? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
