villebro commented on pull request #12649: URL: https://github.com/apache/superset/pull/12649#issuecomment-765547981
> We should probably also revert the metrics/columns select in AdhocMetric/Filter popover back to `react-select` so that the same solution can be applied to address #12640 . Reverting the popover selects to `react-select` feels like a step backwards. Unless there are major issues with the current AntD component, I'd rather try to address any cosmetic issues in the current component which would bring us closer to the long-term stylistic goal. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
