rusackas commented on pull request #12218: URL: https://github.com/apache/superset/pull/12218#issuecomment-765656026
After much discussion with the Preset design team (other voices can pitch in here!) we think we'd like to keep the current arrow directions. As far as arrow **direction** goes, the design proposal is this: If the collapse arrow is on the right side of the content area (like controls), it will point up when open or down when closed.. If it's on the left side of a header (like the Data pane) it will point right when closed, and down when open. The above is more or less in accordance with the Apple [guidelines](https://developer.apple.com/design/human-interface-guidelines/macos/buttons/disclosure-controls/). We should utilize a prop in the Collapse component to pick which version we're using... it appears the `expandIconPosition` could trigger conditional styling. There's also a discrepancy in **animation** - we agreed that they should all be animated (and quickly!) with clockwise rotation when opening, and counterclockwise when closing. And in coming to all these conclusions, we came up with a whole system of floating design proposals as Github Issues, then moving them to the Github wiki when consensus is reached. We'll be sending a proposal around this to the `dev@` list soon! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
